Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.5 Release] Clarify banner on main docs page #7811

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Jan 21, 2025

Summary

As title. Now that we are nearing the release of v0.5.0, the banner on the main page of the documentation can be a bit confusing since the mentioned version will not match. Rather than just updating v0.4.0 to v0.5.0, I believe the banner is trying to convey that our API lifecycle and deprecation policy is in effect as of v0.4.0 which was the beta release of ExecuTorch.

To account for this, I've updated the banner to be more clear on why v0.4.0 is mentioned specifically.

Copy link

pytorch-bot bot commented Jan 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7811

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 30 Pending

As of commit 4db7549 with merge base f2f7e7c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 21, 2025
@mergennachin mergennachin self-requested a review January 21, 2025 22:51
@SS-JIA SS-JIA merged commit b04912f into main Jan 21, 2025
43 of 44 checks passed
@SS-JIA SS-JIA deleted the ssjia-update-doc branch January 21, 2025 23:13
@SS-JIA
Copy link
Contributor Author

SS-JIA commented Jan 21, 2025

@pytorchbot cherry-pick --onto release/0.5 -c docs

pytorchbot pushed a commit that referenced this pull request Jan 21, 2025
Clarify banner on main docs page

(cherry picked from commit b04912f)
@pytorchbot
Copy link
Collaborator

Cherry picking #7811

The cherry pick PR is at #7813 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

SS-JIA added a commit that referenced this pull request Jan 22, 2025
[0.5 Release] Clarify banner on main docs page (#7811)

Clarify banner on main docs page

(cherry picked from commit b04912f)

Co-authored-by: Sicheng Stephen Jia <[email protected]>
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants